Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(lyra): small refactor of variable check #4

Merged
merged 1 commit into from
Jun 20, 2022
Merged

chore(lyra): small refactor of variable check #4

merged 1 commit into from
Jun 20, 2022

Conversation

thomscoder
Copy link
Contributor

I was reading through the code, I really loved this one, and it got me wondering if it is something I'm not getting or if we could just skip a condition and run the check against the returned Map size.

I take this opportunity to tell that I think the ./package.json -> benchmark script contains an outdated path to benchmarks after the build pipeline.

@micheleriva
Copy link
Member

Thank you @thomscoder!
Originally, Lyra was using objects instead of maps, and during the first refactor I forgot to remove those checks.

I'm going to merge this, thanks again

@micheleriva micheleriva merged commit dbef2c5 into oramasearch:main Jun 20, 2022
@thomscoder
Copy link
Contributor Author

Thanks for the explanation :) Best of luck for your next talks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants