Skip to content
This repository has been archived by the owner on Jun 23, 2020. It is now read-only.

Don't open the new page before successful compilation #96

Open
evgenykuzyakov opened this issue Mar 5, 2019 · 3 comments
Open

Don't open the new page before successful compilation #96

evgenykuzyakov opened this issue Mar 5, 2019 · 3 comments
Labels

Comments

@evgenykuzyakov
Copy link
Contributor

Studio opens a new page even if the contract compilation fails.

@vgrichina
Copy link
Contributor

We have to open new page before we know compilation results, as otherwise popup will get blocked (has to be opened as reaction to user action, i.e. Run button).

If it's not closed when compilation fails – it's a bug however. I think there are some edge cases.

@evgenykuzyakov
Copy link
Contributor Author

We should compile on Save (if TS code is modified). And only enable "Run" button when the compilation succeeds

@vgrichina
Copy link
Contributor

let's deal with it after moving from WASMStudio

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants