fix (runtime): Add comments to fees #3073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 4, 2020 10:36
|
|
willemneal
reviewed
Aug 4, 2020
| @@ -10,6 +10,8 @@ pub type Gas = u64; | |||
|
|
|||
| /// Costs associated with an object that can only be sent over the network (and executed | |||
| /// by the receiver). | |||
| /// NOTE: `send_sir` or `send_not_sir` fees are usually burned when the item is being created. | |||
There was a problem hiding this comment.
In the genesis_config.json these two fees are always equal. Wouldn't you expect send_sir to be cheaper?
There was a problem hiding this comment.
All of them are handled the same right now. We don't have optimizations for sir and not_sir
Codecov Report
@@ Coverage Diff @@
## master #3073 +/- ##
=======================================
Coverage 87.38% 87.38%
=======================================
Files 217 217
Lines 42552 42552
=======================================
Hits 37185 37185
Misses 5367 5367 Continue to review full report at Codecov.
|
olonho
approved these changes
Aug 18, 2020
mhalambek
pushed a commit
that referenced
this pull request
Sep 7, 2020
Add more comments to Cost configs.
chefsale
pushed a commit
that referenced
this pull request
Sep 7, 2020
Add more comments to Cost configs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add more comments to Cost configs.