Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - AWS Deployment tests getting skipped because of conditional variable #2622

Closed
marcelovilla opened this issue Aug 13, 2024 · 3 comments

Comments

@marcelovilla
Copy link
Member

Describe the bug

Since a couple weeks ago, our AWS Deployment tests are getting skipped. See:

The issue seems to be with the way we're checking for credentials in order to decide whether we skip the job or not. I believe this behavior was introduced in #2569

Expected behavior

The AWS Deployment tests should not be skipped.

OS and architecture in which you are running Nebari

Not relevant

How to Reproduce the problem?

Run the AWS Deployment workflow manually.

Command output

No response

Versions and dependencies used.

No response

Compute environment

None

Integrations

No response

Anything else?

No response

@BrianCashProf
Copy link
Contributor

This PR will replace the env variable with an action variable set at the repo level.
#2632
To allow for the tests, the following action variables need to be set:
NO_PROVIDER_CREDENTIALS_AWS: 0
NO_PROVIDER_CREDENTIALS_AZURE: 0
NO_PROVIDER_CREDENTIALS_GCP: 0
NO_PROVIDER_CREDENTIALS_DO: 0

@marcelovilla
Copy link
Member Author

Thanks @BrianCashProf! In the near-term future, we'll refactor the cloud provider integration tests so they don't run on a schedule basis but rather after every PR has been merged or before cutting a release. Hopefully this will make it easier for forks to work with that.

@marcelovilla
Copy link
Member Author

I'm closing this issue as #2632 was merged. Thanks @BrianCashProf !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants