Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version tag to qhub header #555

Closed
kcpevey opened this issue May 4, 2021 · 4 comments · Fixed by #1256
Closed

Add version tag to qhub header #555

kcpevey opened this issue May 4, 2021 · 4 comments · Fixed by #1256
Assignees
Labels
area: user experience 👩🏻‍💻 good first issue Good for newcomers needs: review 👀 This PR is complete and ready for reviewing type: enhancement 💅🏼 New feature or request

Comments

@kcpevey
Copy link
Contributor

kcpevey commented May 4, 2021

Description

It would be helpful for end users to have insight into when changes have been made on the deployment.

Suggestion

Given that deployment is automated via CI upon tagging release (at least that’s mostly the case?), I’d like to request that the gh tag be added to the jupyterlab header. We did this in one of the qadmin deployments. Its just helpful for end users to know when a change has been made.

Context

An example - I asked John to update our env for me this morning (since I have no access). He had other things he was dealing with so he did it later in the day. If I had a version tag on the header, I’d be able to see when a change was implemented.

@danlester danlester self-assigned this Jun 8, 2021
@danlester danlester added the good first issue Good for newcomers label Jun 8, 2021
@danlester danlester removed their assignment Jun 18, 2021
@tarundmsharma tarundmsharma added the type: enhancement 💅🏼 New feature or request label Jul 27, 2021
@github-actions
Copy link

This issue has been automatically marked as stale because there was no recent activity in 60 days. Remove the stale label or add a comment, otherwise, this issue will automatically be closed in 7 days if no further activity occurs.

@github-actions github-actions bot added the status: stale 🥖 Not up to date with the default branch - needs update label Sep 27, 2021
@github-actions
Copy link

github-actions bot commented Oct 4, 2021

This issue was closed because it has been stalled for 7 days with no activity.

@github-actions github-actions bot closed this as completed Oct 4, 2021
@trallard trallard added area: user experience 👩🏻‍💻 and removed status: stale 🥖 Not up to date with the default branch - needs update labels Dec 17, 2021
@trallard trallard reopened this Dec 17, 2021
@iameskild iameskild added the needs: investigation 🔍 Someone in the team needs to find the root cause and replicate this bug label Apr 14, 2022
@iameskild iameskild added this to the Release v0.4.1 milestone Apr 14, 2022
@iameskild
Copy link
Member

iameskild commented Apr 14, 2022

Question for the team:

@viniciusdc viniciusdc added status: in progress 🏗 This task is currently being worked on and removed needs: investigation 🔍 Someone in the team needs to find the root cause and replicate this bug labels Apr 19, 2022
@viniciusdc
Copy link
Contributor

Question for the team:

As per the latest discussion on this, there is two addition we can do to benefit the end-user:

  • Add the current qhub version to the Jupyterhub theme pages, this would be similar to Qadmin (as @kcpevey commented)
  • The second one is adding another piece of info in the jupyterhub lab session tab, as suggested in the link above. To do so we would need to update the initialization command for the lab user jupyter lab --name='n-th lab' (I think we are currently adding the user name to that...)

For now, I will submit a PR to address the first point (which is the enchantment requested here) and will open another issue to discuss the second one.

@viniciusdc viniciusdc added needs: review 👀 This PR is complete and ready for reviewing and removed status: in progress 🏗 This task is currently being worked on labels May 5, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: user experience 👩🏻‍💻 good first issue Good for newcomers needs: review 👀 This PR is complete and ready for reviewing type: enhancement 💅🏼 New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants