-
-
Notifications
You must be signed in to change notification settings - Fork 433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
coverage 5.6b1 breaks support for testing code when installed #1143
Comments
Thanks for the reproduction. With coverage 5.5, this is measuring all of the code installed your virtualenv. Then in the reporting phase, you've used With coverage 5.6b1, you will get the same results with I hope you'll agree that this is a better use of coverage.py. This was a good example of the kind of upgrading that people will need to do. |
Yes, this is a much better configuration IMO! Thanks 😊 |
@nedbat in our case this works because we use a source layout. How would one measure coverage on installed files if they are not using the src layout? Also note, while the suggested fix works, this makes 5.6b1 a breaking change for any CI doing any level of strictness check (which I'd hope are a lot). So perhaps this kind of major change should roll out as 6.0 instead. |
@gaborbernat you are probably right about the 6.0 version number. If you weren't using the src layout, |
I think this can be closed now... Please re-open if I am wrong. |
Describe the bug
There are some cases where I want to test if my code works when installed. For this reason, I install the code and run the test suite. This has been working fine so far, but the latest beta breaks our setup.
cc @gaborbernat
To Reproduce
tox -e py39 -e coverage
Patch to pin
coverage
:Expected behavior
As explained above, I would like to be able to track the coverage of my code when I run the test suite with it installed.
The text was updated successfully, but these errors were encountered: