-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
template debug should default to DEBUG #27
Comments
@knyghty Please retry with plugin version 1.4. The plugin now lets Django parse the settings and just checks the result for DJ versions 1.8+ |
@knyghty I hope that the latest version (1.4.1) addresses your issue. If there are no problems reported by Feb 1st, we'll consider this issue closed. |
@PamelaM, I'm not able to test this at the moment but looking at your fix it looks like it should fix the problem, so please go ahead and close it now if you like. |
Thanks |
Per docs it should default to
DEBUG
. I'm not sure if this is django's fault that it isn't explicitly set somehow, or the plugin's fault that it assumes False.In any case, if I'm not mistaken, it can be fixed by changing:
if not template_settings.get('OPTIONS', {}).get('debug', False)
to:
if not template_settings.get('OPTIONS', {}).get('debug', settings.DEBUG)
If
DEBUG
happens to not be in the user's settings file,settings.DEBUG
defaults toFalse
, which seems sensible to me.The text was updated successfully, but these errors were encountered: