actions/download-artifact@v4 downloads wrong file
#2433
Comments
|
After investigating it a little more using #...
- uses: actions/upload-artifact@v3
with:
name: a
path: ./a
if-no-files-found: error
- uses: actions/upload-artifact@v3
with:
name: b
path: ./b
if-no-files-found: error
- uses: actions/download-artifact@v3
with:
name: b
path: ./downloaded
- run: cat downloaded/file.txtoutput: |
malciin
changed the title
-self-hostedactions/download-artifact@v4 downloads wrong file on -self-hosted
|
I'm getting the same on: push
jobs:
test:
runs-on: ubuntu-latest
steps:
- name: Create some files
run: |
mkdir -p /some/nested/folder
echo "file1.txt" >> /some/nested/folder/file1.txt
echo "file2.txt" >> /some/nested/folder/file2.txt
mkdir -p /some/nested/folder/deeper
echo "file3.txt" >> /some/nested/folder/deeper/file3.txt
- name: Upload file1 artifact
uses: actions/upload-artifact@v4
with:
name: file1
path: /some/nested/folder/file1.txt
- name: Upload file2 artifact
uses: actions/upload-artifact@v4
with:
name: file2
path: /some/nested/folder/file2.txt
- name: Upload file3 artifact
uses: actions/upload-artifact@v4
with:
name: file3
path: /some/nested/folder/deeper/file3.txt
- name: Download artifacts
uses: actions/download-artifact@v4
with:
path: /etc/usr/artifacts
pattern: file*
merge-multiple: true
- name: Print directory structure
run: ls -R /etc/usr/artifacts
Run with: Full output: As you can see, only |
malciin
changed the title
actions/download-artifact@v4 downloads wrong file on -self-hostedactions/download-artifact@v4 downloads wrong file
|
This is now the most high priority item of my backlog work starts soon. ProblemAll artifacts have the same id and downloading is using the id when merging multiple artifacts Todo find a way to provide id's from artifact name or change directory structure Then create a test to enshure this works correctly. Gitea and runner.server versions of the backend are using database id's those have been stripped away while porting |
|
Please test #2505, pr checks contain binaries if needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug report info
Command used with act
act -P windows=-self-hosted -j test --artifact-server-path ./artifactsDescribe issue
I've found that
actions/download-artifact@v4can download invalid file (even tho name input parameter is specified) when running with-self-hostedflag.If I use workflow like:
it will correctly print
b content, however if we uncomment these lines we'll get a warning:::warning::Multiple artifacts found, defaulting to first.because of following following response:{ "artifacts": [ { "workflowRunBackendId": "1", "workflowJobRunBackendId": "1", "databaseId": "1", "name": "a", "createdAt": "2024-08-22T17:37:41.104232900Z" }, { "workflowRunBackendId": "1", "workflowJobRunBackendId": "1", "databaseId": "1", "name": "b", "createdAt": "2024-08-22T17:37:31.607801900Z" } ] }And
cat downloaded/file.txtwill printa contentbecause it downloadedaartifact not thebartifact.Link to GitHub repository
No response
Workflow content
Relevant log output
[Bugged/test] 💬 ::debug::Body: {%0A "artifacts": [%0A {%0A "workflowRunBackendId": "1",%0A "workflowJobRunBackendId": "1",%0A "databaseId": "1",%0A "name": "a",%0A "createdAt": "2024-08-22T17:37:41.104232900Z"%0A },%0A {%0A "workflowRunBackendId": "1",%0A "workflowJobRunBackendId": "1",%0A "databaseId": "1",%0A "name": "b",%0A "createdAt": "2024-08-22T17:37:31.607801900Z"%0A }%0A ]%0A} [Bugged/test] 🚧 ::warning::Multiple artifacts found, defaulting to first. [Bugged/test] 💬 ::debug::[Request] GetSignedArtifactURL http://192.168.31.59:34567/twirp/github.actions.results.api.v1.ArtifactService/GetSignedArtifactURL [Bugged/test] 💬 ::debug::[Response] - 200 [Bugged/test] 💬 ::debug::Headers: {%0A "content-type": "application/json;charset=utf-8",%0A "date": "Thu, 22 Aug 2024 17:40:41 GMT",%0A "content-length": "237"%0A} [Bugged/test] 💬 ::debug::Body: {%0A "signedUrl": "http://192.168.31.59:34567/twirp/github.actions.results.api.v1.ArtifactService/DownloadArtifact?sig=o_ckWtmUh0AtNWvkayk1-5nBauAc3xsTsRGgS21syzk=&expires=2024-08-22+20%253A40%253A41.2640052+%252B0200+CEST&artifactName=a&taskID=1"%0A} | Redirecting to blob download url: http://192.168.31.59:34567/twirp/github.actions.results.api.v1.ArtifactService/DownloadArtifact | Starting download of artifact to: C:\Users\Marcin\.cache\act\12edfb9afc9aa2b3\hostexecutor\downloaded | (node:18208) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead. | (Use `node --trace-deprecation ...` to show where the warning was created) | Artifact download completed successfully. | Total of 1 artifact(s) downloaded | Download artifact has finished successfully [Bugged/test] ✅ Success - Main actions/download-artifact@v4 [Bugged/test] ⚙ ::set-output:: download-path=C:\Users\Marcin\.cache\act\12edfb9afc9aa2b3\hostexecutor\downloaded [Bugged/test] ⭐ Run Main cat downloaded/file.txt | a content [Bugged/test] ✅ Success - Main cat downloaded/file.txt [Bugged/test] Cleaning up container for job test [Bugged/test] 🏁 Job succeededAdditional information
No response
The text was updated successfully, but these errors were encountered: