Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mount volume for workflow info #776

Merged
merged 2 commits into from
Sep 24, 2021

Conversation

catthehacker
Copy link
Member

Mounts volume for /var/run/act into master and slave/nested containers from a workflow

fixes #747

@catthehacker catthehacker requested a review from a team as a code owner August 11, 2021 09:15
@codecov
Copy link

codecov bot commented Aug 11, 2021

Codecov Report

Merging #776 (c5eb35d) into master (0f04942) will increase coverage by 5.07%.
The diff coverage is 61.37%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #776      +/-   ##
==========================================
+ Coverage   49.27%   54.34%   +5.07%     
==========================================
  Files          23       23              
  Lines        2401     3682    +1281     
==========================================
+ Hits         1183     2001     +818     
- Misses       1090     1529     +439     
- Partials      128      152      +24     
Impacted Files Coverage Δ
pkg/container/docker_build.go 0.00% <0.00%> (ø)
pkg/container/docker_run.go 2.86% <0.00%> (+0.93%) ⬆️
pkg/common/git.go 49.82% <31.81%> (-9.97%) ⬇️
pkg/runner/runner.go 70.73% <38.46%> (-5.74%) ⬇️
pkg/model/planner.go 49.78% <42.50%> (+16.70%) ⬆️
pkg/model/workflow.go 52.14% <63.63%> (+26.42%) ⬆️
pkg/container/docker_pull.go 36.36% <64.00%> (+18.18%) ⬆️
pkg/runner/expression.go 85.71% <72.09%> (-0.93%) ⬇️
pkg/runner/step_context.go 79.48% <79.05%> (+10.53%) ⬆️
pkg/runner/run_context.go 81.85% <91.08%> (+5.44%) ⬆️
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e82f17e...c5eb35d. Read the comment docs.

@mergify
Copy link
Contributor

mergify bot commented Aug 11, 2021

@catthehacker this pull request has failed checks 🛠

@github-actions
Copy link
Contributor

PR is stale and will be closed in 14 days unless there is new activity

@github-actions github-actions bot added the stale label Sep 24, 2021
@catthehacker catthehacker added stale-exempt Exempt from stale and removed stale labels Sep 24, 2021
@mergify
Copy link
Contributor

mergify bot commented Sep 24, 2021

@catthehacker this pull request has failed checks 🛠

@mergify mergify bot added needs-work Extra attention is needed and removed needs-work Extra attention is needed labels Sep 24, 2021
@mergify mergify bot merged commit 3c14548 into nektos:master Sep 24, 2021
@catthehacker catthehacker deleted the cat/fix/mount-act-path branch September 27, 2021 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS stale-exempt Exempt from stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue: Unable to set GitHub environment variable
2 participants