feat: allow existing logger from context #898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #898 +/- ##
==========================================
+ Coverage 49.27% 56.13% +6.86%
==========================================
Files 23 26 +3
Lines 2401 3962 +1561
==========================================
+ Hits 1183 2224 +1041
- Misses 1090 1536 +446
- Partials 128 202 +74
Continue to review full report at Codecov.
|
ZauberNerd
force-pushed
the
reuse-logger
branch
from
3f1eb62
to
d5a1fe3
Compare
catthehacker
previously approved these changes
Nov 25, 2021
cplee
previously approved these changes
Nov 26, 2021
We should reuse an existing context logger if in test context. This will allow test to setup act with a null logger to assert log messages. Co-authored-by: Markus Wolf <markus.wolf@new-work.se>
ZauberNerd
force-pushed
the
reuse-logger
branch
from
d5a1fe3
to
be91b48
Compare
|
@catthehacker @cplee had to rebase against master, because "Allow maintainer edits" doesn't work for organization accounts: isaacs/github#1681 |
catthehacker
approved these changes
Nov 26, 2021
cplee
approved these changes
Nov 27, 2021
ZauberNerd
added a commit
to xing/act
that referenced
this pull request
Nov 30, 2021
* nektos#898 * nektos#891 have both been merged upstream, so they're no longer required here.
ZauberNerd
added a commit
to xing/act
that referenced
this pull request
Nov 30, 2021
* nektos#898 * nektos#891 have both been merged upstream, so they're no longer required here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should reuse an existing context logger if in test context.
This will allow test to setup act with a null logger to assert
log messages.