fix: runtime load logo for footer #4
Conversation
|
Tested in stage |
.env.development
Outdated
| @@ -7,7 +7,7 @@ LOGOUT_URL='http://localhost:18000/login' | |||
| LOGO_URL=https://edx-cdn.org/v3/default/logo.svg | |||
| LOGO_TRADEMARK_URL=https://edx-cdn.org/v3/default/logo-trademark.svg | |||
| LOGO_WHITE_URL=https://edx-cdn.org/v3/default/logo-white.svg | |||
| LOGO_POWERED_BY_OPEN_EDX_URL_SVG=https://edx-cdn.org/v3/stage/open-edx-tag.svg | |||
| LOGO_POWERED_BY_OPEN_EDX_URL_SVG='' | |||
There was a problem hiding this comment.
are you deploying the development package ?
There was a problem hiding this comment.
No, but is a way to also make it work in local dev.
johanseto
force-pushed
the
jlc/fix-footer-logo
branch
from
c181e36 to
c0e0036
Compare
| @@ -27,7 +28,7 @@ const App = () => ( | |||
| /> | |||
| </Switch> | |||
| </main> | |||
| <Footer logo={process.env.LOGO_POWERED_BY_OPEN_EDX_URL_SVG} /> | |||
| <Footer logo={getConfig().LOGO_TRADEMARK_URL || process.env.LOGO_POWERED_BY_OPEN_EDX_URL_SVG} /> | |||
There was a problem hiding this comment.
Why you didn't change this line https://github.com/openedx/frontend-component-footer/blob/master/src/components/Footer.jsx#L59 ?
There was a problem hiding this comment.
Because in that line I have to modify frontend-component-footer. That package is in NPM, and yes is possible to make a fork starting for the actual version but my concern is that to keep it to upstream that component could affect all MFEs. So keeping it here I fixed it in the gradebook where I found the footer logo was not runtime. Learning and discussions seem working...
|
@johanseto After merging please complete the track file |
johanseto
force-pushed
the
jlc/fix-cdn
branch
5 times, most recently
from
ae0d7aa to
3309cdd
Compare
johanseto
force-pushed
the
jlc/fix-footer-logo
branch
from
c0e0036 to
55ae694
Compare
johanseto
force-pushed
the
jlc/fix-footer-logo
branch
from
55ae694 to
7e4698b
Compare
Description
as you can see if logo is not falsy, the runtimevalue doesnt work.
https://github.com/openedx/frontend-component-footer/blob/master/src/components/Footer.jsx#L59
but gradebook loaded with this value
https://github.com/openedx/frontend-app-gradebook/blob/open-release/palm.master/src/App.jsx#L30
Testing Instructions
Add setting for footer logo in mfe runtime.
eg
Before
after