chore: downgrade axios version in order to improve compatibility #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanseto
reviewed
Jan 17, 2024
The test error is something that is happening also in the target version, as I mentioned in the description that comes from the branch ags/2331and that includes that error On the other hand the other error is because you need to set the EXAMS_BASE_URL, you need to set that to an empty string. |
andrey-canon
force-pushed
the
open-release/palm.nelp
branch
from
84cbeec to
84c6d76
Compare
andrey-canon
force-pushed
the
and/downgrade_axios
branch
from
66ad491 to
013932c
Compare
johanseto
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The target version (open-release/palm.nelp) is a copy of this branch which is necessary to use the frontend-platform version that allows to inject css styles, however the target version includes a the axios 1.4.0 version which is not compatible with the axios-mock-adapter library, so when this version is included in packages like frontend-app-learning the axios version is updated and the test starts to fail
Before
After