Contract Permission exception still affecting neo #2890

[cschuchardt88]

Describe the bug
#2890 issue is still affecting ListContracts in the neo.dll

This exception was originally thrown at this call stack:
    Neo.SmartContract.Manifest.ContractPermissionDescriptor.ContractPermissionDescriptor(System.ReadOnlySpan<byte>) in ContractPermissionDescriptor.cs
    Neo.SmartContract.Manifest.ContractManifest.Neo.SmartContract.IInteroperable.FromStackItem.AnonymousMethod__29_3(Neo.VM.Types.StackItem) in ContractManifest.cs
    System.Linq.Enumerable.SelectEnumerableIterator<TSource, TResult>.ToArray() in Select.SpeedOpt.cs
    Neo.SmartContract.Manifest.ContractManifest.Neo.SmartContract.IInteroperable.FromStackItem(Neo.VM.Types.StackItem) in ContractManifest.cs
    Neo.SmartContract.Helper.ToInteroperable<T>(Neo.VM.Types.StackItem) in Helper.cs
    Neo.SmartContract.ContractState.Neo.SmartContract.IInteroperable.FromStackItem(Neo.VM.Types.StackItem) in ContractState.cs
    Neo.SmartContract.StorageItem.GetInteroperable<T>() in StorageItem.cs
    Neo.SmartContract.Native.ContractManagement.ListContracts.AnonymousMethod__15_0((Neo.SmartContract.StorageKey Key, Neo.SmartContract.StorageItem Value)) in ContractManagement.cs
    System.Linq.Enumerable.SelectEnumerableIterator<TSource, TResult>.ToArray() in Select.SpeedOpt.cs
    System.Linq.Buffer<TElement>.Buffer(System.Collections.Generic.IEnumerable<TElement>) in Buffer.cs

To Reproduce
Steps to reproduce the behavior:

var contracts = NativeContract.ContractManagement.ListContracts(_neosystem.StoreView);
if (contracts.Any() == false) return NoContent();
var contractRequestList = contracts.OrderBy(o => o.Manifest.Name);
if (contractRequestList.Any() == false) return NoContent(); // crashes here when reading data

Expected behavior

internal ContractPermissionDescriptor(ReadOnlySpan<byte> span)
{
    switch (span.Length)
    {
        case UInt160.Length:
            Hash = new UInt160(span);
            break;
        case 33:
            Group = ECPoint.DecodePoint(span, ECCurve.Secp256r1);
            break;
        case 0:
            // wildcard logic
        default:
            throw new ArgumentException(null, nameof(span));
    }
}

Screenshots

Platform:

• OS: Windows 10 Pro 22H2 19045.3324
• Version neo.dll 3.6.0

(Optional) Additional context

System.ArgumentException: 'Value does not fall within the expected range. (Parameter 'span')'

[roman-khimov]

Have you resynchronized your DB? 3.6.0 requires that.

[cschuchardt88]

Yes but this time i get

System.InvalidCastException: 'Specified cast is not valid.'

This exception was originally thrown at this call stack:
    Neo.VM.Types.StackItem.GetSpan()
    Neo.SmartContract.Manifest.ContractManifest.Neo.SmartContract.IInteroperable.FromStackItem.AnonymousMethod__29_3(Neo.VM.Types.StackItem) in ContractManifest.cs
    System.Linq.Enumerable.SelectEnumerableIterator<TSource, TResult>.ToArray() in Select.SpeedOpt.cs
    Neo.SmartContract.Manifest.ContractManifest.Neo.SmartContract.IInteroperable.FromStackItem(Neo.VM.Types.StackItem) in ContractManifest.cs
    Neo.SmartContract.Helper.ToInteroperable<T>(Neo.VM.Types.StackItem) in Helper.cs
    Neo.SmartContract.ContractState.Neo.SmartContract.IInteroperable.FromStackItem(Neo.VM.Types.StackItem) in ContractState.cs
    Neo.SmartContract.StorageItem.GetInteroperable<T>() in StorageItem.cs
    Neo.SmartContract.Native.ContractManagement.ListContracts.AnonymousMethod__15_0((Neo.SmartContract.StorageKey Key, Neo.SmartContract.StorageItem Value)) in ContractManagement.cs
    System.Linq.Enumerable.SelectEnumerableIterator<TSource, TResult>.ToArray() in Select.SpeedOpt.cs
    System.Linq.Buffer<TElement>.Buffer(System.Collections.Generic.IEnumerable<TElement>) in Buffer.cs
    ...
    [Call Stack Truncated]

neo/src/Neo/SmartContract/Manifest/ContractManifest.cs

Line 84 in 4e9314d

Array array => WildcardContainer<ContractPermissionDescriptor>.Create(array.Select(p => new ContractPermissionDescriptor(p.GetSpan())).ToArray()),

[shargon]

Using testnet data and last core code, I'm not receive any error parsing the contracts

Now testing with mainnet....