Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checklist of 3.7.x PRs that will cause FORK #3233

Closed
3 of 4 tasks
vang1ong7ang opened this issue May 14, 2024 · 3 comments
Closed
3 of 4 tasks

checklist of 3.7.x PRs that will cause FORK #3233

vang1ong7ang opened this issue May 14, 2024 · 3 comments

Comments

@vang1ong7ang
Copy link
Contributor

vang1ong7ang commented May 14, 2024

not seem to have learned from #2910, the new release of neo node (v3.7.x) still has some weaknesses that lead to fork

at least the following PRs are included:

risks caused by this situation have been explained in the discussion of #2910, but it is worth emphasizing that:

since the state between the old and new versions differs, any clients (exchanges and explorers included) that upgrade before or after the consensus upgrading are able to be cheated because there is always a window period in which their ledgers are different.

@shargon
Copy link
Member

shargon commented May 16, 2024

#3130 is for OS machine in BigEndian, and previously it doesn't work, so I think no one is affected, because they can't run a node

@vang1ong7ang
Copy link
Contributor Author

since most of items are fixed in #3234, propose to close this issue

@Jim8y
Copy link
Contributor

Jim8y commented May 17, 2024

close as complete in #3234

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants