Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add UTF-8 support to JSONProperty #835

Closed
wants to merge 4 commits into from
Closed

Add UTF-8 support to JSONProperty #835

wants to merge 4 commits into from

Conversation

danikirish
Copy link
Contributor

Implements #834

@danikirish danikirish mentioned this pull request Oct 13, 2024
Closed
@mariusconjeaud mariusconjeaud changed the base branch from master to rc/5.4.0 October 28, 2024 08:33
@mariusconjeaud
Copy link
Collaborator

Thank you !

Could you add a test for this ?

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@mariusconjeaud mariusconjeaud linked an issue Nov 5, 2024 that may be closed by this pull request
Allow to store UTF-8 values in JSONProperty #834
Closed
@mariusconjeaud
Copy link
Collaborator

Replaced with #838 ; I fixed the tests, and pushed the code but accidentally created a new branch instead of pushing to your fork.
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow to store UTF-8 values in JSONProperty
2 participants
@danikirish @mariusconjeaud