Fixes signature help bug with default arguments in VSCode #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 798d0bc The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ncordon
commented
Nov 7, 2024
| }); | ||
|
|
||
| const argsString = argDescriptions.map((arg) => arg.label).join(', '); | ||
| const signature = `${name}(${argsString})`; |
There was a problem hiding this comment.
This ensures the signature is computed with whatever is returned in the argument descriptions
ncordon
changed the title
ncordon
commented
Nov 7, 2024
|
|
||
| return SignatureInformation.create( | ||
| signature, | ||
| description, | ||
| ...argumentDescription.map((arg) => ({ | ||
| label: `${arg.name} :: ${arg.type}`, |
There was a problem hiding this comment.
The problem is that the highlighting on the signature gets done matching against this. If the signature of a specific argument includes a default value (e.g = ms) but here we didn't have it, then it wasn't been highlighted in blue.
OskarDamkjaer
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
After