Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove udc.source from 4.0.x #234

Merged
merged 3 commits into from
Mar 5, 2020
Merged

Remove udc.source from 4.0.x #234

merged 3 commits into from
Mar 5, 2020

Conversation

bfeshti
Copy link
Contributor

@bfeshti bfeshti commented Mar 4, 2020

Since udc.source is deprecated starting from neo4j 4.0 there is no sense into keeping it in the docker image.

@bfeshti bfeshti requested a review from jennyowen March 4, 2020 14:45
jennyowen
jennyowen requested changes Mar 5, 2020
View reviewed changes
Copy link
Member

@jennyowen jennyowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! It's always nice to be able to delete source code. There's just a minor change to the test and it's ready to merge.

src/test/java/com/neo4j/docker/TestConfSettings.java Outdated Show resolved Hide resolved
@bfeshti bfeshti merged commit 7e6d4b6 into master Mar 5, 2020
@bfeshti bfeshti deleted the Remove_udc.source_from_4.0.x branch March 5, 2020 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jennyowen jennyowen jennyowen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bfeshti @jennyowen