Enable the Causal Clustering tests on 4.0 series #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stopped Neo4j from granting read/write permissions to all on mounted folders. It will still change the folder owner if the docker container is not started using the --user flag though (for backwards compatibility). Improved warning messages when mounting folders. Added helpful error message for when mounting folders fails, including troubleshooting tips. Refactored tests and added a few new test cases I encountered includes PR neo4j#165 Hopefully fixes: neo4j#164 neo4j#130 As I was making changes I noticed a bug when setting passwords that occurs when running docker without --user flag. I fixed that too (hopefully). I believe this may also solve neo4j#147 and neo4j#163
merge public repo with bug fixes
The background here is that - again - the Debian OpenJDK builds turn out to have the wrong version numbers on them, with the package being stamped as a java update that was released after the package was built. See https://mail.openjdk.java.net/pipermail/jdk8u-dev/2019-May/009330.html We don't use the Debian packages, we use Alpine, but inspecting the provenance of the Alpine OpenKJDK packaging, it seems to suffer from the same issue. The current latest alpine OpenJDK has versioning that does not seem to line up. At the very least, the source of those builds is of a similar kind to Debian. This moves our base image to images provided by AdoptOpenJDK, a well regarded source of up-to-date OpenJDK builds. The base image remains Alpine Linux.
Switch to AdoptOpenJDK-based JVM base image
Jake/mergeadoptopenjdk
Run `make package` to build a sharable package of the docker image.
Check groups when determining if a directory is writable
Renamed folders and merged source from https://github.com/neo-technology/new-docker-tests
Add NEO4JLABS_PLUGINS support for neosemantics (n10s)
This reverts commit a9c12d5
Remove udc.source from 4.0.x
…y break in windows.
folders mounted under neo4j home were only give read access to `root` instead of `neo4j`. Change neo4j#237 applied a chmod 700 to *all* files and folders under home instead of ones that were only owned by root. This meant that all mounted files under home which were not owned by neo4j became unreadable.
adding graph-data-science to NEO4JLABS_PLUGINS
We were using a Neo4jContainer from TestContainers rather than a GenericContainer and this seems to have caused the /data/dbms directory to get built unexpectedly. The data/dbms folder contains authentication information, and it turns out that Neo4jContainer was setting a default password even though NEO4J_AUTH=none is set, hence the folder appeared and out tests passed. I've added an initial password so that the folder is created and we can test permissions on it.
jennyowen
force-pushed
the
master
branch
2 times, most recently
from
1ce4aac
to
7986a74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.