Fix hyperlinks by opening a new tab in background using browser.tabs #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix and close #3
I am not a fan of this html syntax and I saw it was repeatedly changed in past commits, might be a good idea to edit prettier config? Though I have no idea how it works and I probably should actually look into it on my own.
This suggested keeping the actual href but it was getting cluttered and the whole extension wouldn't work with javascript disabled so I think it's safe to keep a
#placeholder and rely on the@clickevent.I set the new tabs to open without focus as changing tabs closes the popup and loses eventual progress, might be cool to persist the state until the page is closed or something like that.