Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coding_guidelines: correct term from "alphabetical" to "chronological" order #5402

Closed
gplanansky opened this issue May 10, 2024 · 2 comments
Closed
Labels
bug Something isn't working stale

Comments

@gplanansky
Copy link
Contributor

https://github.com/neomjs/neo/blob/2001220a26c5c763102aa5fdc27bc6bf9af13463/.github/CODING_GUIDELINES.md

Should not "chronological" be "alphabetical"?

(19) Class content order:

    static configs (ordered chronologically)
    static config as the last item. This one does not need a comment, but is prefixed with an empty line.
    non-static class fields (ordered chronologically)
    construct() in case you are using it
    all other class methods are ordered chronologically and are prefixed with an empty line.
@gplanansky gplanansky added the bug Something isn't working label May 10, 2024
Copy link

This issue is stale because it has been open for 90 days with no activity.

@github-actions github-actions bot added the stale label Aug 28, 2024
Copy link

This issue was closed because it has been inactive for 14 days since being marked as stale.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stale
Projects
None yet
Development

No branches or pull requests

1 participant