Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't hardcode .cmd/.exe extensions #185

Closed
dherman opened this issue Feb 10, 2017 · 0 comments
Closed

don't hardcode .cmd/.exe extensions #185

dherman opened this issue Feb 10, 2017 · 0 comments

Comments

@dherman
Copy link
Collaborator

dherman commented Feb 10, 2017

The build.rs scripts in various places have to shell out to executables. Instead of hard-coding .cmd and .exe extensions in Windows, just call cmd.exe /C node and cmd.exe /C npm. That way if Node changes the extension of its executables, the invocations will still work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant