Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API for getting the global object #249

Closed
dherman opened this issue Sep 22, 2017 · 3 comments
Closed

API for getting the global object #249

dherman opened this issue Sep 22, 2017 · 3 comments

Comments

@dherman
Copy link
Collaborator

dherman commented Sep 22, 2017

There needs to be an API for getting at the global object. In the V8 API you can get this from v8::Context::Global(). In Neon it should probably be a method of Scope, something like:

fn global(&mut self) -> Handle<JsObject>;
@reSHARMA
Copy link

I am new to neon , but I really want to contribute on this issue . Can you guide me what should I do next ?

@dherman
Copy link
Collaborator Author

dherman commented Oct 11, 2017

@reSHARMA So sorry, @GabrielCastro got to this one first with #253. I'm planning to spend some time tomorrow finding more good tasks for first-time contributors.

@dherman
Copy link
Collaborator Author

dherman commented Oct 11, 2017

Fixed in #253.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants