Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

agent: Plugin/NeonVM/Monitor metrics with retries #1012

Open
Tracked by #594
Omrigan opened this issue Jul 19, 2024 · 0 comments
Open
Tracked by #594

agent: Plugin/NeonVM/Monitor metrics with retries #1012

Omrigan opened this issue Jul 19, 2024 · 0 comments

Comments

@Omrigan
Copy link
Contributor

Omrigan commented Jul 19, 2024

Plugin/NeonVM/Monitor metrics we currently have do not count retries, i. e. measure each individual request separately.

Another way to express the same problem is for every scaling session TotalPlugin+TotalNeonVM+TotalMonitor should be equal to total e2e latency.

In order to count the retries also, we must not do TargetRevision: s.TargetRevision.WithTime(now) every time a request is planned. Rather, we update the time once per concrete revision value, and not update it if more request happen with the same revision.

We should also have monitor downscale/upscale metrics separate, as downscale usually needs many more retries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant