Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layer deletion operation can be lost in case of a pageserver crash/restart #4326

Closed
LizardWizzard opened this issue May 24, 2023 · 2 comments
Labels
c/storage/pageserver Component: storage: pageserver c/storage Component: storage t/bug Issue Type: Bug triaged bugs that were already triaged

Comments

@LizardWizzard
Copy link
Contributor

Steps to reproduce

  1. Schedule layer deletion
  2. Upload index_file.json change
  3. Crash before actual deletion is done

Expected result

Layer should be deleted

Actual result

Layer wont be deleted. It is no longer in the index file and there is nothing that detects those. One option to solve it would be to persist delete intention in the index file first, then by looking at the index file after restart deletions can be retried.

Environment

Logs, links

@LizardWizzard LizardWizzard added t/bug Issue Type: Bug c/storage/pageserver Component: storage: pageserver c/storage Component: storage labels May 24, 2023
@LizardWizzard
Copy link
Contributor Author

The same can happen during upload, if we uploaded the layer successfully but index file wasnt updated. Likely after restart there upload operation will be retried, so in this case there is no actual leakage.

@shanyp
Copy link
Contributor

shanyp commented Jun 1, 2023

#4378

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/storage/pageserver Component: storage: pageserver c/storage Component: storage t/bug Issue Type: Bug triaged bugs that were already triaged
Projects
None yet
Development

No branches or pull requests

4 participants