Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TUI: exepath is set to PATH twice on Windows #22572

Open
erw7 opened this issue Mar 8, 2023 · 1 comment
Open

TUI: exepath is set to PATH twice on Windows #22572

erw7 opened this issue Mar 8, 2023 · 1 comment
Labels
bug issues reporting wrong behavior platform:windows remote remote UI, --remote commands, p2p / peer-to-peer tui

Comments

@erw7
Copy link
Contributor

erw7 commented Mar 8, 2023

Problem

exepath is set to PATH twice.

Perhaps exepath was added in tui and more exepath was added in server. The design of #18375 is wrong. The TUI and server code should be separated. Ad hoc code that branches conditional on ui_client_channel_id should not be written.
Cc: @bfredl

Steps to reproduce

set PATH=C:\Windows;C:\Windows\System32
nvim --clean
:echo $PATH
C:\Windows;C:\Windows\System32;C:\Neovim\bin;C:\Neovim\bin " If neovim is located at C:\Neovim\bin.

Expected behavior

exepath is set to PATH only once.

Neovim version (nvim -v)

cce7362 or later

Vim (not Nvim) behaves the same?

N/A

Operating system/version

Windows

Terminal name/version

N/A

$TERM environment variable

N/A

Installation

zip of release page

@erw7 erw7 added bug issues reporting wrong behavior platform:windows tui labels Mar 8, 2023
@bfredl
Copy link
Member

bfredl commented Mar 8, 2023

The design of #18375 is wrong.. The TUI and server code should be separated.

That's... exactly what it already does. Also see follow up PR:s which disentangles them further.

Ad hoc code that branches conditional on ui_client_channel_id should not be written.

Feel free to write other sorts of code to solve this particular issue 👍

@justinmk justinmk added the remote remote UI, --remote commands, p2p / peer-to-peer label Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug issues reporting wrong behavior platform:windows remote remote UI, --remote commands, p2p / peer-to-peer tui
Projects
None yet
Development

No branches or pull requests

3 participants