From f80695aed190a79bc3fea2ed193985250468b571 Mon Sep 17 00:00:00 2001 From: Rafal Jankowski Date: Wed, 1 Feb 2023 15:36:30 +0100 Subject: [PATCH 1/2] Fixed lack of repr for StringifyValue --- .../neptune/new/test_stringify_unsupported.py | 22 +++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/tests/unit/neptune/new/test_stringify_unsupported.py b/tests/unit/neptune/new/test_stringify_unsupported.py index f0c2f4908..b74ae6168 100644 --- a/tests/unit/neptune/new/test_stringify_unsupported.py +++ b/tests/unit/neptune/new/test_stringify_unsupported.py @@ -86,6 +86,28 @@ def test_assign__float(self, run): assert run["with_warning"].fetch() == run["no_warning"].fetch() + def test_assign__array(self, run): + values = [Obj(), Obj(), Obj()] + + with assert_deprecation_warning(): + run["with_warning"] = values + + with assert_no_warnings(): + run["no_warning"] = stringify_unsupported(values) + + assert run["with_warning"].fetch() == run["no_warning"].fetch() + + def test_assign__array_inside_dict(self, run): + values = [Obj(), Obj(), Obj()] + + with assert_deprecation_warning(): + run["with_warning"] = {"array": values} + + with assert_no_warnings(): + run["no_warning"] = stringify_unsupported({"array": values}) + + assert run["with_warning"]["array"].fetch() == run["no_warning"]["array"].fetch() + def test_assign__float__reassign(self, run): with assert_deprecation_warning(): run["with_warning"] = 4.0 From c7bdd58ef460af3cf0f45a13114497a49f82a282 Mon Sep 17 00:00:00 2001 From: Rafal Jankowski Date: Wed, 1 Feb 2023 15:37:55 +0100 Subject: [PATCH 2/2] CHANGELOG updated --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 2c90b02b1..2b2334bc8 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,7 @@ ### Fixes - Added support of tuple in stringify_unsupported ([#1196](https://github.com/neptune-ai/neptune-client/pull/1196)) +- Fixed lack of `__repr__` for `StringifyValue` ([#1195](https://github.com/neptune-ai/neptune-client/pull/1195)) ## neptune-client 0.16.16