Merge pull request #4255 from yangby-cryptape/no-chain_root-in-1st-bl…

…ock-of-mmr-activated-epoch fix: no chain_root in 1st block of the mmr activated epoch
nervosnetwork · Dec 8, 2023 · 98a583d · 98a583d
2 parents 3d674d5 + ee78320
commit 98a583d
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/util/types/src/utilities/merkle_mountain_range.rs b/util/types/src/utilities/merkle_mountain_range.rs
@@ -209,8 +209,9 @@ impl VerifiableHeader {
     }
 
     /// Checks if the current verifiable header is valid.
-    pub fn is_valid(&self, mmr_activated_epoch: EpochNumber) -> bool {
-        let has_chain_root = self.header().epoch().number() >= mmr_activated_epoch;
+    pub fn is_valid(&self, mmr_activated_epoch_number: EpochNumber) -> bool {
+        let mmr_activated_epoch = EpochNumberWithFraction::new(mmr_activated_epoch_number, 0, 1);
+        let has_chain_root = self.header().epoch() > mmr_activated_epoch;
         if has_chain_root {
             if self.header().is_genesis() {
                 if !self.parent_chain_root().is_default() {