Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rpc truncate leak #3941

Closed
zhangsoledad opened this issue Apr 17, 2023 · 0 comments · Fixed by #3948
Closed

Fix rpc truncate leak #3941

zhangsoledad opened this issue Apr 17, 2023 · 0 comments · Fixed by #3948
Assignees
@chenyukang
Labels
t:bug Type: This doesn't seem right.

Comments

@zhangsoledad
Copy link
Member

zhangsoledad commented Apr 17, 2023 •
edited
Loading

Bug Report

Current Behavior

https://github.com/nervosnetwork/ckb/tree/develop/rpc#method-truncate
The truncate rpc is often used when testing, but truncate now has a defect, it will read all the selected blocks into memory at once, when truncate a long chain will be a memory leak and crash

Expected Behavior

Truncate can be performed in segments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chenyukang chenyukang

Labels
t:bug Type: This doesn't seem right.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix bug in truncate RPC all and add limit for better error message chenyukang/ckb
2 participants
@chenyukang @zhangsoledad