Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(script): make ResumableMachine type public #4046

Merged
merged 2 commits into from
Jun 28, 2023
Merged

chore(script): make ResumableMachine type public #4046

merged 2 commits into from
Jun 28, 2023

Conversation

mohanson
Copy link
Contributor

What problem does this PR solve?

Problem Summary:

ckb-debugger has no chance to get suspended machine instances at now.

What is changed and how it works?

What's Changed:

Public these structures/functions.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

  • None

Release note 

None: Exclude this PR from the release note.

@mohanson mohanson requested a review from a team as a code owner June 28, 2023 01:26
@mohanson mohanson requested review from doitian and removed request for a team June 28, 2023 01:26
@mohanson
Copy link
Contributor Author

Can this PR be included in v0.111.0?

@zhangsoledad zhangsoledad mentioned this pull request Jun 28, 2023
Merged
@zhangsoledad
Copy link
Member

Can this PR be included in v0.111.0?

sure can. https://github.com/nervosnetwork/ckb/pull/4048/files

@zhangsoledad zhangsoledad added this pull request to the merge queue Jun 28, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jun 28, 2023
@zhangsoledad zhangsoledad added this pull request to the merge queue Jun 28, 2023
Merged via the queue into nervosnetwork:develop with commit 1271cdf Jun 28, 2023
@mohanson mohanson deleted the pub-resumable-machine branch June 30, 2023 07:36
@doitian doitian mentioned this pull request Jul 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eval-exec eval-exec eval-exec approved these changes

@zhangsoledad zhangsoledad zhangsoledad approved these changes

@doitian doitian Awaiting requested review from doitian doitian is a code owner automatically assigned from nervosnetwork/ckb-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mohanson @zhangsoledad @eval-exec