Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tweak SendBlocksProof message to support ckb2023 #4185

Merged
merged 2 commits into from
Oct 27, 2023

Conversation

quake
Copy link
Member

@quake quake commented Oct 11, 2023

What problem does this PR solve?

There is a new syscall load_extension in ckb2023 hardfork, but current light client protocol doesn't provide the extension field, it causes the client to be unable to support validation of transactions that use this syscall.

What is changed and how it works?

This pr adds two fields blocks_uncles_hash and blocks_extension to the SendBlocksProof and SendTransactionsProof message, they may be used to verify the header field extra_hash, client can store the extension data when verification passed.

Check List

Tests

  • Unit test
  • Integration test

Release note

Title Only: Include only the PR title in the release note.

@quake quake force-pushed the quake/light-client-extension branch from c8d2014 to 1a7bfad Compare October 23, 2023 11:30
@quake quake marked this pull request as ready for review October 26, 2023 23:52
@quake quake requested a review from a team as a code owner October 26, 2023 23:52
@quake quake requested review from zhangsoledad, yangby-cryptape and a team and removed request for a team October 26, 2023 23:52
@quake quake added this pull request to the merge queue Oct 27, 2023
Merged via the queue into nervosnetwork:develop with commit 34dbc77 Oct 27, 2023
35 checks passed
@doitian doitian mentioned this pull request Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants