Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix peer store random fetch #4289

Merged
merged 1 commit into from
Jan 3, 2024
Merged

fix: fix peer store random fetch #4289

merged 1 commit into from
Jan 3, 2024

Conversation

driftluo
Copy link
Collaborator

@driftluo driftluo commented Jan 2, 2024

What problem does this PR solve?

Fix bug：

  1. The propagation address obtained by discovery from the peer store should be one that has been connected locally within seven days, and the check of the address that keeps the connection should not be skipped.
  2. To determine if the IP is duplicated, we need to confirm that the address has been selected.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Release note

Title Only: Include only the PR title in the release note.

@driftluo driftluo requested a review from a team as a code owner January 2, 2024 07:33
@driftluo driftluo requested review from zhangsoledad and quake and removed request for a team and zhangsoledad January 2, 2024 07:33
@zhangsoledad zhangsoledad added this pull request to the merge queue Jan 3, 2024
Merged via the queue into nervosnetwork:develop with commit ec399af Jan 3, 2024
34 checks passed
@driftluo driftluo deleted the fix-peer-store-random-fetch branch January 3, 2024 04:18
@doitian doitian mentioned this pull request Jan 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eval-exec eval-exec eval-exec approved these changes

@zhangsoledad zhangsoledad zhangsoledad approved these changes

@quake quake quake approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@driftluo @quake @zhangsoledad @eval-exec