Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backport: Fix the regex expression for ckb's version test #4325

Merged
merged 2 commits into from
Jan 25, 2024
Merged

backport: Fix the regex expression for ckb's version test #4325

merged 2 commits into from
Jan 25, 2024

Conversation

chenyukang
Copy link
Collaborator

What's Changed:

  • Fix the regex expression to match ckb version string like ckb 0.113.0 (82871a3 2024-01-09) or ckb 0.113.0-rc3 (3287c63 2024-01-02)

Check List

Tests

  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

  • None

Release note 

None: Exclude this PR from the release note.

@chenyukang chenyukang requested a review from a team as a code owner January 25, 2024 12:41
@quake quake merged commit b08187b into nervosnetwork:rc/v0.113.x Jan 25, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eval-exec eval-exec eval-exec approved these changes

@quake quake quake approved these changes

@zhangsoledad zhangsoledad Awaiting requested review from zhangsoledad zhangsoledad is a code owner automatically assigned from nervosnetwork/ckb-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chenyukang @quake @eval-exec