-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IndexerService::apply_init_tip
should stop after received exit signal.
#4345
Merged
quake
merged 3 commits into
nervosnetwork:develop
from
eval-exec:exec/fix-indexer-exit-signal
Feb 8, 2024
Merged
IndexerService::apply_init_tip
should stop after received exit signal.
#4345
quake
merged 3 commits into
nervosnetwork:develop
from
eval-exec:exec/fix-indexer-exit-signal
Feb 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quake
approved these changes
Feb 8, 2024
Review verification passed, ctrl c can exit the ckb process normally, the relevant log content is as follows:
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #4311
Problem Summary:
In the
apply_init_tip
function, there is a loop that should take into account the exit signal:ckb/util/indexer/src/service.rs
Lines 156 to 172 in 1ee9c98
Additionally, once
initial_syncing
is finished and CKB receives an exit signal, there is no need to spawn thenew_block_watcher
polling job.What's Changed:
Related changes
apply_init_tip
Check List
Tests
Side effects
Release note