Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bury rfc0044 deploy #4430

Merged

Conversation

zhangsoledad
Copy link
Member

@zhangsoledad zhangsoledad commented Apr 22, 2024

What is changed and how it works?

This hardcodes RFC0044 activation epochs. makes it easier to understand light client protocol activation status, and reduces technical debt

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Side effects

Release note

Title Only: Include only the PR title in the release note.

@zhangsoledad zhangsoledad requested a review from a team as a code owner April 22, 2024 08:07
@zhangsoledad zhangsoledad requested review from quake and removed request for a team April 22, 2024 08:07
eval-exec
eval-exec previously approved these changes Apr 22, 2024
doitian
doitian previously approved these changes Apr 22, 2024
@doitian doitian mentioned this pull request Apr 23, 2024
@zhangsoledad zhangsoledad force-pushed the zhangsoledad/bury-rfc43 branch 2 times, most recently from 34ca11a to 34a6433 Compare April 23, 2024 03:22
eval-exec
eval-exec previously approved these changes Apr 23, 2024
@zhangsoledad
Copy link
Member Author

off-by-one adaptation fixe #4255

@zhangsoledad zhangsoledad added this pull request to the merge queue Apr 24, 2024
Merged via the queue into nervosnetwork:develop with commit 1fcb58c Apr 24, 2024
32 checks passed
@zhangsoledad zhangsoledad deleted the zhangsoledad/bury-rfc43 branch April 24, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants