Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: reject transactions has less gas than the intrinsic gas #725

Merged
merged 2 commits into from
Jun 14, 2022
Merged

fix: reject transactions has less gas than the intrinsic gas #725

merged 2 commits into from
Jun 14, 2022

Conversation

jjyr
Copy link
Collaborator

@jjyr jjyr commented Jun 13, 2022 •
edited by Flouse
Loading

@jjyr jjyr requested review from Flouse, magicalne and zeroqn June 13, 2022 08:39
@jjyr jjyr force-pushed the reject-insufficient-intrinsic-gas-txs branch from a737640 to f6d0c5e Compare June 13, 2022 08:43
@gw-bot

This comment was marked as outdated.

Sign in to view
@godwokenrises godwokenrises deleted a comment from gw-bot bot Jun 13, 2022
magicalne
magicalne previously approved these changes Jun 13, 2022
View reviewed changes
@Flouse
Copy link
Collaborator

Flouse commented Jun 14, 2022 •
edited
Loading

/itest

Flouse
Flouse previously approved these changes Jun 14, 2022
View reviewed changes
crates/utils/src/polyjuice_parser.rs Show resolved Hide resolved
@jjyr @Flouse
chore: reference to godwoken-polyjuice doc
0f8fb16 
Co-authored-by: Flouse <flouse@gmail.com>
@jjyr jjyr dismissed stale reviews from Flouse and magicalne via 0f8fb16 June 14, 2022 03:21
@jjyr jjyr requested review from Flouse and magicalne June 14, 2022 03:21
@gw-bot
Copy link

gw-bot bot commented Jun 14, 2022 •
edited
Loading

Running integration test

Workflow Run Id: 2492568173

Components:

Manually running integration test

Post a comment contains

/itest
[prebuilds: tag]
[godwoken: branch/ref]
[scripts: branch/ref]
[polyjuice: branch/ref]
[web3: branch/ref]
[kicker: branch/ref]
[tests: branch/ref]

Note: [] means optional, for example

/itest
prebuilds: dev-202203280240
godwoken: develop
scripts: 81676d9d53ffdf5bbaa60483928d07da16eb4a88
polyjuice: e37553b9

Run Result

cancelled

@jjyr jjyr merged commit 6905a78 into godwokenrises:develop Jun 14, 2022
@jjyr jjyr deleted the reject-insufficient-intrinsic-gas-txs branch June 14, 2022 05:55
@Flouse
Copy link
Collaborator

Flouse commented Jun 14, 2022

/itest

@gw-bot
Copy link

gw-bot bot commented Jun 14, 2022 •
edited
Loading

Running integration test

Workflow Run Id: 2496377480

Components:

Manually running integration test

Post a comment contains

/itest
[prebuilds: tag]
[godwoken: branch/ref]
[scripts: branch/ref]
[polyjuice: branch/ref]
[web3: branch/ref]
[kicker: branch/ref]
[tests: branch/ref]

Note: [] means optional, for example

/itest
prebuilds: dev-202203280240
godwoken: develop
scripts: 81676d9d53ffdf5bbaa60483928d07da16eb4a88
polyjuice: e37553b9

Run Result

failure

Run Result

failure

@jjyr jjyr mentioned this pull request Jun 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flouse Flouse Flouse approved these changes

@zeroqn zeroqn Awaiting requested review from zeroqn

@magicalne magicalne Awaiting requested review from magicalne

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jjyr @Flouse @magicalne