Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redirect syscall debug logs #758

Merged
merged 4 commits into from
Jul 14, 2022
Merged

Redirect syscall debug logs #758

merged 4 commits into from
Jul 14, 2022

Conversation

magicalne
Copy link
Contributor

Now we can send contract logs to sentry if we hit an error.
There are 3 modes In ContractLogConfig:

  • Default - Just like the old times. And will not send to sentry.
  • Redirect - Redirect logs to a spawned task and print them all.
  • RedirectError - Redirect logs to a spawned task and only print logs if the exit code is not 0.

@gw-bot

This comment was marked as outdated.

Sign in to view
@gw-bot

This comment was marked as outdated.

Sign in to view
@gw-bot
Copy link

gw-bot bot commented Jul 13, 2022 •
edited
Loading

Running integration test

Workflow Run Id: 2660845553

Components:

Manually running integration test

Post a comment contains

/itest
[prebuilds: tag]
[godwoken: branch/ref]
[scripts: branch/ref]
[polyjuice: branch/ref]
[web3: branch/ref]
[kicker: branch/ref]
[tests: branch/ref]

Note: [] means optional, for example

/itest
prebuilds: dev-202203280240
godwoken: develop
scripts: 81676d9d53ffdf5bbaa60483928d07da16eb4a88
polyjuice: e37553b9

Run Result

success

@jjyr jjyr requested review from jjyr, zeroqn and Flouse July 13, 2022 03:49
jjyr
jjyr reviewed Jul 13, 2022
View reviewed changes
crates/generator/src/syscalls/redir_log.rs Outdated Show resolved Hide resolved
crates/generator/src/syscalls/redir_log.rs Outdated Show resolved Hide resolved
@jjyr jjyr requested review from blckngm and removed request for Flouse July 13, 2022 04:10
blckngm
blckngm reviewed Jul 13, 2022
View reviewed changes
crates/generator/src/syscalls/redir_log.rs Outdated Show resolved Hide resolved
crates/generator/src/syscalls/mod.rs Outdated Show resolved Hide resolved
@gw-bot
Copy link

gw-bot bot commented Jul 13, 2022 •
edited
Loading

Running integration test

Workflow Run Id: 2661774108

Components:

Manually running integration test

Post a comment contains

/itest
[prebuilds: tag]
[godwoken: branch/ref]
[scripts: branch/ref]
[polyjuice: branch/ref]
[web3: branch/ref]
[kicker: branch/ref]
[tests: branch/ref]

Note: [] means optional, for example

/itest
prebuilds: dev-202203280240
godwoken: develop
scripts: 81676d9d53ffdf5bbaa60483928d07da16eb4a88
polyjuice: e37553b9

Run Result

success

@gw-bot
Copy link

gw-bot bot commented Jul 14, 2022 •
edited
Loading

Running integration test

Workflow Run Id: 2667529126

Components:

Manually running integration test

Post a comment contains

/itest
[prebuilds: tag]
[godwoken: branch/ref]
[scripts: branch/ref]
[polyjuice: branch/ref]
[web3: branch/ref]
[kicker: branch/ref]
[tests: branch/ref]

Note: [] means optional, for example

/itest
prebuilds: dev-202203280240
godwoken: develop
scripts: 81676d9d53ffdf5bbaa60483928d07da16eb4a88
polyjuice: e37553b9

Run Result

success

@gw-bot
Copy link

gw-bot bot commented Jul 14, 2022 •
edited
Loading

Running integration test

Workflow Run Id: 2667604601

Components:

Manually running integration test

Post a comment contains

/itest
[prebuilds: tag]
[godwoken: branch/ref]
[scripts: branch/ref]
[polyjuice: branch/ref]
[web3: branch/ref]
[kicker: branch/ref]
[tests: branch/ref]

Note: [] means optional, for example

/itest
prebuilds: dev-202203280240
godwoken: develop
scripts: 81676d9d53ffdf5bbaa60483928d07da16eb4a88
polyjuice: e37553b9

Run Result

success

@magicalne magicalne requested review from jjyr, blckngm and zeroqn July 14, 2022 03:25
@jjyr jjyr merged commit f6bbd5e into godwokenrises:develop Jul 14, 2022
@magicalne magicalne deleted the syscall_debug_redir branch July 14, 2022 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeroqn zeroqn zeroqn approved these changes

@blckngm blckngm blckngm approved these changes

@jjyr jjyr jjyr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@magicalne @jjyr @blckngm @zeroqn