Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rpc): calculate tx signature hash using packed bytes #760

Merged
merged 1 commit into from
Jul 19, 2022
Merged

fix(rpc): calculate tx signature hash using packed bytes #760

merged 1 commit into from
Jul 19, 2022

Conversation

zeroqn
Copy link
Contributor

@zeroqn zeroqn commented Jul 18, 2022

packed bytes contains size header, should use raw bytes.

@zeroqn
fix(rpc): calculate tx signature hash using packed bytes
af298ab 
packed bytes contains size header, should use raw bytes.
@zeroqn zeroqn requested a review from classicalliu July 18, 2022 13:20
@gw-bot
Copy link

gw-bot bot commented Jul 18, 2022 •
edited
Loading

Running integration test

Workflow Run Id: 2690804038

Components:

Manually running integration test

Post a comment contains

/itest
[prebuilds: tag]
[godwoken: branch/ref]
[scripts: branch/ref]
[polyjuice: branch/ref]
[web3: branch/ref]
[kicker: branch/ref]
[tests: branch/ref]

Note: [] means optional, for example

/itest
prebuilds: dev-202203280240
godwoken: develop
scripts: 81676d9d53ffdf5bbaa60483928d07da16eb4a88
polyjuice: e37553b9

Run Result

failure

@zeroqn zeroqn requested review from Flouse, jjyr and blckngm July 19, 2022 00:34
@zeroqn
Copy link
Contributor Author

zeroqn commented Jul 19, 2022

/itest
web3: 4d3dddc5881fedf0dbb8cce8a250aa423f9f5e99
scripts: master

@gw-bot
Copy link

gw-bot bot commented Jul 19, 2022 •
edited
Loading

Running integration test

Workflow Run Id: 2694402051

Components:

Manually running integration test

Post a comment contains

/itest
[prebuilds: tag]
[godwoken: branch/ref]
[scripts: branch/ref]
[polyjuice: branch/ref]
[web3: branch/ref]
[kicker: branch/ref]
[tests: branch/ref]

Note: [] means optional, for example

/itest
prebuilds: dev-202203280240
godwoken: develop
scripts: 81676d9d53ffdf5bbaa60483928d07da16eb4a88
polyjuice: e37553b9

Run Result

failure

@jjyr jjyr merged commit 87d48b5 into godwokenrises:develop Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blckngm blckngm blckngm approved these changes

@jjyr jjyr jjyr approved these changes

@Flouse Flouse Flouse approved these changes

@classicalliu classicalliu Awaiting requested review from classicalliu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zeroqn @Flouse @jjyr @blckngm