fix(mempool): pool cycles not reset on next mem block for readonly node #781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Flouse
previously approved these changes
Aug 12, 2022
blckngm
previously approved these changes
Aug 12, 2022
zeroqn
dismissed stale reviews from blckngm and Flouse
The base branch was changed.
Flouse
previously approved these changes
Aug 12, 2022
magicalne
previously approved these changes
Aug 12, 2022
Right now, fullnode publish tx only after finalization. But we should not depend on this behaviour. For readonly node, we should verify cylces instead of blindly trust fullnode.
This comment was marked as outdated.
This comment was marked as outdated.
In case we migrate to dynamic config in the future
Running integration testWorkflow Run Id: 2845569683 Components:
Manually running integration testPost a comment contains Note: Run Resultsuccess |
Flouse
added a commit
that referenced
this pull request
Aug 15, 2022
…de (#781) * fix(mempool): pool cycles not reset on next mem block for readonly node (#781) * fix(mempool): verify txs from fullnode Right now, fullnode publish tx only after finalization. But we should not depend on this behaviour. For readonly node, we should verify cylces instead of blindly trust fullnode. * refactor(mempool): recreate cycles pool from config In case we migrate to dynamic config in the future
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.