Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omega forced to be positive #90

Closed
LucaNap opened this issue Dec 9, 2022 · 5 comments
Closed

Omega forced to be positive #90

LucaNap opened this issue Dec 9, 2022 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@LucaNap
Copy link

LucaNap commented Dec 9, 2022

Recently, I had an issue where "omega_p#" wasn't being added to the posteriors file.
Apparently the culprit are the following lines in utils.py:

idx = np.where(omega > 0.)[0]
val, valup, valdown = get_quantiles(omega[idx])

While my planet's omega was never going above 0, so the function resulted in no values at all.
Shouldn't omega be defined between -180 and 180, as indicated in Eastmanl 2013 (and as suggested by the conversion factor 180/np.pi) ? Isn't this causing any omega output to be plain wrong ?

P.S. I am using the "sesinomega, secosomega" parametrization.

@nespinoza nespinoza self-assigned this Feb 15, 2023
@nespinoza
Copy link
Owner

Hey @LucaNap --- sorry for not taking a look at this earlier. This indeed seems like a bug. I'll take a look a this!

@nespinoza nespinoza added the bug Something isn't working label Feb 15, 2023
@LucaNap
Copy link
Author

LucaNap commented Apr 23, 2023

Thank you @nespinoza . This bug is still standing, and it's very annoying because sometimes the fit ends up with a negative omega, so omega[idx] fails and the fit function comes up with an error.

@nespinoza
Copy link
Owner

Hi @LucaNap,

I just fixed this in the latest juliet version --- v.2.2.4. Can you please try upgrading and checking this works there? Namely, do pip install juliet --upgrade, and check your posteriors.dat.

Will wait until your confirmation before closing this!

N.

@LucaNap
Copy link
Author

LucaNap commented Nov 15, 2023

Unfortunately I don't remember which target I was testing last year; but the code looks ok! I'll let you know if I find any issues on this topic in the future. Thanks!

@nespinoza
Copy link
Owner

Solved in v.2.2.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants