-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Omega forced to be positive #90
Comments
Hey @LucaNap --- sorry for not taking a look at this earlier. This indeed seems like a bug. I'll take a look a this! |
Thank you @nespinoza . This bug is still standing, and it's very annoying because sometimes the fit ends up with a negative omega, so omega[idx] fails and the fit function comes up with an error. |
Hi @LucaNap, I just fixed this in the latest Will wait until your confirmation before closing this! N. |
Unfortunately I don't remember which target I was testing last year; but the code looks ok! I'll let you know if I find any issues on this topic in the future. Thanks! |
Solved in v.2.2.4 |
Recently, I had an issue where "omega_p#" wasn't being added to the posteriors file.
Apparently the culprit are the following lines in utils.py:
While my planet's omega was never going above 0, so the function resulted in no values at all.
Shouldn't omega be defined between -180 and 180, as indicated in Eastmanl 2013 (and as suggested by the conversion factor 180/np.pi) ? Isn't this causing any omega output to be plain wrong ?
P.S. I am using the "sesinomega, secosomega" parametrization.
The text was updated successfully, but these errors were encountered: