Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loosen dependency requirements #211

Open
rolisz opened this issue Oct 23, 2023 · 2 comments
Open

Loosen dependency requirements #211

rolisz opened this issue Oct 23, 2023 · 2 comments

Comments

@rolisz
Copy link

rolisz commented Oct 23, 2023

This library has several very specific requirements (eg: numpy==1.24.4, scipy==1.10.1, pandas==1.3.5, etc.). In Python it's usually best practice for libraries to specify ranges of versions for their dependencies, because otherwise they become hard to install and lead to conflicts.

Would you be open to this? I can send a PR for this.

@india-kerle
Copy link
Collaborator

india-kerle commented Dec 6, 2023

Hey @rolisz! Go for it - feel free to open a PR with your suggested changes.

@sqr00t
Copy link
Contributor

sqr00t commented Dec 6, 2023

Another good practice to reduce development creep is not to maintain version pins for common dependencies so often. I'm inclining towards changing dependencies to >= latest.compatible.version

We've also identified issues for new users due to upstream updates from Pydantic and SpaCy, as well as small improvements for imports. @rolisz I'd be happy to include your contributions from your PR while addressing these issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants