Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CQRS event handlers doc #2476

Closed
1 task done
CDelgrange opened this issue Sep 30, 2022 · 6 comments
Closed
1 task done

Improve CQRS event handlers doc #2476

CDelgrange opened this issue Sep 30, 2022 · 6 comments

Comments

@CDelgrange
Copy link
Contributor

Is there an existing issue that is already proposing this?

  • I have searched the existing issues

Is your feature request related to a problem? Please describe it

The "problem" is already known, you can find details in this issue.

TLDR: When you start using CQRS events / event handlers, you get out of the traditional HTTP web context. There are multiple solutions to solve this behavior, but the point here, is that it's not documented anywhere and it can lead to unexpected crashes.

Describe the solution you'd like

A simple Hint in the doc explaining that behavior and what to expect in order to react appropriately.

Teachability, documentation, adoption, migration strategy

Here is what I would like to add to the doc:
cqrs doc

What is the motivation / use case for changing the behavior?

It's not changing the behavior, it's just inform people for better communication and some time saved for everyone.

@kamilmysliwiec kamilmysliwiec transferred this issue from nestjs/nest Sep 30, 2022
@kamilmysliwiec kamilmysliwiec transferred this issue from nestjs/cqrs Sep 30, 2022
@CDelgrange
Copy link
Contributor Author

@Tony133 No offense, but could you let met create that PR please ?
As you probably guessed thanks to the screenshot of the issue, I already made the changes. I don't know why - probably because I'm not used to contribute to open source projects - but I thought that someone had to approve my new opened issue before pushing the code associated to it...
And because it's my first time to contribute to open source project I was "proud" to contribute following the whole process 😅

@Tony133
Copy link
Contributor

Tony133 commented Oct 3, 2022

Hi @CDelgrange, no problem, as soon as you do the PR I close mine 👍

No, an issue does not have to be approved, to create a PR.

If you want future contributions to the NestJS repositories you directly open a PR with what you think needs to be changed, without creating an issue, then it will be evaluated and approved in code review ,etc

Let's say it is a "faster" step.

@CDelgrange
Copy link
Contributor Author

Thanks a lot @Tony133 👌

Noted ! :)

@Tony133
Copy link
Contributor

Tony133 commented Oct 3, 2022

You're welcome, it's nothing. 😉👍

I closed my PR

@Tony133
Copy link
Contributor

Tony133 commented Nov 1, 2022

This issue we can close since the merge has been done here: #2486

@CDelgrange
Copy link
Contributor Author

You're right 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants