Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors in default webpack config file (webpack.config.json) are silently ignored #2421

Closed
2 of 4 tasks
Glandos opened this issue Dec 12, 2023 · 1 comment · Fixed by #2627
Closed
2 of 4 tasks

Errors in default webpack config file (webpack.config.json) are silently ignored #2421

Glandos opened this issue Dec 12, 2023 · 1 comment · Fixed by #2627

Comments

@Glandos
Copy link

Glandos commented Dec 12, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Current behavior

When a webpack.config.js has some error (either syntax or runtime), this is silently ignored, and replaced with default configuration.

See https://github.com/nestjs/nest-cli/blame/a95b21e02ff9333b48264ae5f1d2d9b941f56a36/actions/build.action.ts#L272

I guess this was done to ignore FileNotFound errors, but then, only this error should be ignored.

Minimum reproduction code

https://example.com

Steps to reproduce

No response

Expected behavior

Error from default configuration file should be reported

Package version

10.2.1

NestJS version

10.2.10

Node.js version

v16.20.2

In which operating systems have you tested?

  • macOS
  • Windows
  • Linux

Other

No response

@kamilmysliwiec
Copy link
Member

Would you like to create a PR for this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants