Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider supporting reflect-metadata@^0.2.1 #12926

Closed
1 task done
notaphplover opened this issue Dec 16, 2023 · 5 comments
Closed
1 task done

Consider supporting reflect-metadata@^0.2.1 #12926

notaphplover opened this issue Dec 16, 2023 · 5 comments
Labels
needs triage This issue has not been looked into type: enhancement 🐺

Comments

@notaphplover
Copy link

Is there an existing issue that is already proposing this?

  • I have searched the existing issues

Is your feature request related to a problem? Please describe it

NestJs libraries have a peer dependency of reflect-metadata@^0.1.12, so 0.2.X versions are not supported (consider docs) as reference.

Describe the solution you'd like

Since reflect-metadata@0.2.X are not introducing any breaking changes, it would be great if they could be accepted in the range of the peer dependencies.

Teachability, documentation, adoption, migration strategy

The migration strategy would consist in updating package peer dependencies to also allow reflect-metadata@0.2.X

What is the motivation / use case for changing the behavior?

Updating reflect-metadata dependencies of my packages that are implemented on top of the NestJS framework.

@notaphplover notaphplover added needs triage This issue has not been looked into type: enhancement 🐺 labels Dec 16, 2023
@schiller-manuel
Copy link

schiller-manuel commented Dec 16, 2023

Should nestjs then use the newly introduced reflect-metadata/lite export?
see rbuckton/reflect-metadata#144

@KostyaTretyak
Copy link

KostyaTretyak commented Dec 17, 2023

Should nestjs then use the newly introduced reflect-metadata/lite export? see rbuckton/reflect-metadata#144

From the linked PR:

The polyfill-free /lite and /no-conflict exports require a runtime or bundler that supports package.json subpath exports.

So, as far as I understand, reflect-metadata/lite will be used in NestJS only after migration to ECMAScript modules.

@schiller-manuel
Copy link

Is the migration to ESM on the horizon?

@kamilmysliwiec
Copy link
Member

#12943

@notaphplover
Copy link
Author

notaphplover commented Jan 17, 2024

@kamilmysliwiec there seems to be trouble in the CI to merge #12943, would it be ok if we submit a PR to properly update the constraints? Once its merged it will allow renovatebot to properly update example packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage This issue has not been looked into type: enhancement 🐺
Projects
None yet
Development

No branches or pull requests

4 participants