-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nest crash when RouteConstraints is used without app versioning enabled #13496
Comments
@micalevisk please assign me this issue, I'll file a PR to add a warning if app versioning is not enabled |
Would you like to create a PR for this issue? |
Yes, will do |
Fcmam5
added a commit
to Fcmam5/fastify-route-constraints-poc
that referenced
this issue
May 4, 2024
Fcmam5
added a commit
to Fcmam5/nest
that referenced
this issue
May 5, 2024
12 tasks
Fcmam5
added a commit
to Fcmam5/nest
that referenced
this issue
May 5, 2024
Fcmam5
added a commit
to Fcmam5/fastify-route-constraints-poc
that referenced
this issue
May 5, 2024
Let's track this here #13536 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is there an existing issue for this?
Current behavior
After some testing, there is an untested case that crashes Nest when using RouteConstraints and app versioning is not set in fastify context.
Related to: #12567
Minimum reproduction code
Steps to reproduce are easy, no need repo
Steps to reproduce
Expected behavior
A catch with a warning to prevent user to enable app versioning before using RouteConstraints decorator.
@Fcmam5 this maybe requires to add an additional test to catch this case.
Package
@nestjs/common
@nestjs/core
@nestjs/microservices
@nestjs/platform-express
@nestjs/platform-fastify
@nestjs/platform-socket.io
@nestjs/platform-ws
@nestjs/testing
@nestjs/websockets
Other package
No response
NestJS version
10.3.6
Packages versions
Node.js version
20.12.1
In which operating systems have you tested?
Other
No response
The text was updated successfully, but these errors were encountered: