Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validating data sources configurations #2017

Open
1 task done
Motii1 opened this issue Jul 8, 2024 · 0 comments
Open
1 task done

Validating data sources configurations #2017

Motii1 opened this issue Jul 8, 2024 · 0 comments
Labels

Comments

@Motii1
Copy link

Motii1 commented Jul 8, 2024

Is there an existing issue that is already proposing this?

  • I have searched the existing issues

Is your feature request related to a problem? Please describe it

The application is allowed to have multiple data sources with the same name

Describe the solution you'd like

In the documentation there is a warning:

If you don't set the name for a data source, its name is set to default.
Please note that you shouldn't have multiple connections without a name, 
or with the same name, otherwise they will get overridden.

Since it is not recommended it would be nice to fail the application startup if more than one data source with the same name is detected

Teachability, documentation, adoption, migration strategy

The warning in the documentation could be adjusted

What is the motivation / use case for changing the behavior?

At my company, we are creating multiple data sources. We encountered an issue where we inadvertently created several data sources with identical names, which is something we should avoid. This oversight led to numerous problems and required significant time to debug. While my preferred solution is outlined above, I understand it would involve a breaking change. Therefore, I would be satisfied with at least a warning log message to prevent this issue in the future.

@Motii1 Motii1 added the feature label Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant