Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find a way to survive KSPCF's ~~Stupidity~~ *Less Than Smartness*. #62

Closed
Lisias opened this issue Mar 20, 2023 · 5 comments
Closed

Find a way to survive KSPCF's ~~Stupidity~~ *Less Than Smartness*. #62

Lisias opened this issue Mar 20, 2023 · 5 comments
Assignees
Labels
Not My Fault Not my Fault! I'm innocent! :) task Not a problem, but something I must do and should not forget about
Milestone

Comments

@Lisias
Copy link
Contributor

Lisias commented Mar 20, 2023

So, KSPCF decided to blindly disable KSP-Recall, whatever their fixes are active or not.

KSPModdingLibs/KSPCommunityFixes#124

https://github.com/KSPModdingLibs/KSPCommunityFixes/blob/1.24.6/GameData/KSPCommunityFixes/MMPatches/ModSupport/KSPRecall.cfg (currently the latest)

@PART[*]:HAS[@MODULE[Refunding]]:NEEDS[KSPRECALL-REFUNDING]:FINAL
{
	!MODULE[Refunding]{}
}

@KSP-Recall:AFTER[999_KSP-Recall]
{
  @INSTALLED
  {
    @Refunding = false
  }
}

And there's no way I can civilly overcome this crap, I will need to brute force my way on the problem.

OBJECTIVE

Find the less brute and intrusive way to allow users to activate the updated Refunding if this is what they want.

Some people is going to yell on me for sure - as it would be any difference by now. :/

@Lisias Lisias added the Not My Fault Not my Fault! I'm innocent! :) label Mar 20, 2023
@Lisias Lisias added this to the 0.3.0.13 milestone Mar 20, 2023
@Lisias Lisias self-assigned this Mar 20, 2023
@Lisias Lisias added the task Not a problem, but something I must do and should not forget about label Mar 20, 2023
@net-lisias-ksp net-lisias-ksp deleted a comment from gotmachine Mar 22, 2023
@Lisias Lisias changed the title Find a way to survive KSPCF's Stupidity. Find a way to survive KSPCF's ~~Stupidity~~ *Less than smartness*. Mar 22, 2023
@Lisias
Copy link
Contributor Author

Lisias commented Mar 22, 2023

Hope to had made someone more happy today. :D

@Lisias Lisias changed the title Find a way to survive KSPCF's ~~Stupidity~~ *Less than smartness*. Find a way to survive KSPCF's ~~Stupidity~~ *Less Than Smartness*. Mar 22, 2023
@net-lisias-ksp net-lisias-ksp locked as resolved and limited conversation to collaborators Mar 23, 2023
@Lisias
Copy link
Contributor Author

Lisias commented Mar 23, 2023

Well, this is what I had done:

  1. Split the current Refunding Stunt in two PartModules
    • One will deal exclusively to the original problem
    • The other will try to handle the float precision problem
  2. And, yeah, a new MetaResource will be added.
    • (sigh)
  3. Both PartModules can be individually activated or deactivated.

@Lisias
Copy link
Contributor Author

Lisias commented Mar 24, 2023

Implemented on commit 6f7aa4c

Additionally, the Meta Resources are not created anymore when they are not needed. This will shrink a bit the surface of the exposition of the solutionhack.

@Lisias
Copy link
Contributor Author

Lisias commented Mar 24, 2023

Now I need to retest the following Issues:

@Lisias
Copy link
Contributor Author

Lisias commented Mar 25, 2023

Oukey. All tests are good. Closing this.

@Lisias Lisias closed this as completed Mar 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Not My Fault Not my Fault! I'm innocent! :) task Not a problem, but something I must do and should not forget about
Projects
None yet
Development

No branches or pull requests

1 participant