Improve errExit error messages

Changes: * Move msg to the end of errExit (right before perror(3p)) * Include the full file path (within the repository) * Add "()" to function name for clarity Before: Error malloc: main.c:123 main: Cannot allocate memory After: Error src/firejail/main.c:123 main(): malloc: Cannot allocate memory Note: This clarifies which is the exact file that the error message comes from, as there are many source files with the same name. For example: $ git ls-files 'src/*/main.c' | wc -l 20
netblue30 · Jun 28, 2023 · b963fe4 · b963fe4
1 parent e06c3e9
commit b963fe4
Show file tree

Hide file tree

Showing 28 changed files with 29 additions and 3 deletions.
diff --git a/config.mk.in b/config.mk.in
@@ -83,7 +83,7 @@ LDFLAGS=@LDFLAGS@
 # Project variables
 EXTRA_CFLAGS  =@EXTRA_CFLAGS@
 COMMON_CFLAGS = \
-	-ggdb -O2 -DVERSION='"$(VERSION)"' \
+	-ggdb -O2 -DVERSION='"$(VERSION)"' -DMOD_DIR='"$(MOD_DIR)"' \
 	-Wall -Wextra $(HAVE_FATAL_WARNINGS) \
 	-Wformat -Wformat-security \
 	-fstack-protector-all -D_FORTIFY_SOURCE=2 \

diff --git a/src/etc-cleanup/Makefile b/src/etc-cleanup/Makefile
@@ -2,6 +2,7 @@
 ROOT = ../..
 -include $(ROOT)/config.mk
 
+MOD_DIR = src/etc-cleanup
 PROG = etc-cleanup
 TARGET = $(PROG)
 

diff --git a/src/fbuilder/Makefile b/src/fbuilder/Makefile
@@ -2,6 +2,7 @@
 ROOT = ../..
 -include $(ROOT)/config.mk
 
+MOD_DIR = src/fbuilder
 PROG = fbuilder
 TARGET = $(PROG)
 

diff --git a/src/fcopy/Makefile b/src/fcopy/Makefile
@@ -2,6 +2,7 @@
 ROOT = ../..
 -include $(ROOT)/config.mk
 
+MOD_DIR = src/fcopy
 PROG = fcopy
 TARGET = $(PROG)
 

diff --git a/src/fids/Makefile b/src/fids/Makefile
@@ -2,6 +2,7 @@
 ROOT = ../..
 -include $(ROOT)/config.mk
 
+MOD_DIR = src/fids
 PROG = fids
 TARGET = $(PROG)
 

diff --git a/src/firecfg/Makefile b/src/firecfg/Makefile
@@ -2,6 +2,7 @@
 ROOT = ../..
 -include $(ROOT)/config.mk
 
+MOD_DIR = src/firecfg
 PROG = firecfg
 TARGET = $(PROG)
 

diff --git a/src/firejail/Makefile b/src/firejail/Makefile
@@ -2,6 +2,7 @@
 ROOT = ../..
 -include $(ROOT)/config.mk
 
+MOD_DIR = src/firejail
 PROG = firejail
 TARGET = $(PROG)
 

diff --git a/src/firemon/Makefile b/src/firemon/Makefile
@@ -2,6 +2,7 @@
 ROOT = ../..
 -include $(ROOT)/config.mk
 
+MOD_DIR = src/firemon
 PROG = firemon
 TARGET = $(PROG)
 

diff --git a/src/fldd/Makefile b/src/fldd/Makefile
@@ -2,6 +2,7 @@
 ROOT = ../..
 -include $(ROOT)/config.mk
 
+MOD_DIR = src/fldd
 PROG = fldd
 TARGET = $(PROG)
 

diff --git a/src/fnet/Makefile b/src/fnet/Makefile
@@ -2,6 +2,7 @@
 ROOT = ../..
 -include $(ROOT)/config.mk
 
+MOD_DIR = src/fnet
 PROG = fnet
 TARGET = $(PROG)
 

diff --git a/src/fnetfilter/Makefile b/src/fnetfilter/Makefile
@@ -2,6 +2,7 @@
 ROOT = ../..
 -include $(ROOT)/config.mk
 
+MOD_DIR = src/fnetfilter
 PROG = fnetfilter
 TARGET = $(PROG)
 

diff --git a/src/fnettrace-dns/Makefile b/src/fnettrace-dns/Makefile
@@ -2,6 +2,7 @@
 ROOT = ../..
 -include $(ROOT)/config.mk
 
+MOD_DIR = src/fnettrace-dns
 PROG = fnettrace-dns
 TARGET = $(PROG)
 

diff --git a/src/fnettrace-icmp/Makefile b/src/fnettrace-icmp/Makefile
@@ -2,6 +2,7 @@
 ROOT = ../..
 -include $(ROOT)/config.mk
 
+MOD_DIR = src/fnettrace-icmp
 PROG = fnettrace-icmp
 TARGET = $(PROG)
 

diff --git a/src/fnettrace-sni/Makefile b/src/fnettrace-sni/Makefile
@@ -2,6 +2,7 @@
 ROOT = ../..
 -include $(ROOT)/config.mk
 
+MOD_DIR = src/fnettrace-sni
 PROG = fnettrace-sni
 TARGET = $(PROG)
 

diff --git a/src/fnettrace/Makefile b/src/fnettrace/Makefile
@@ -2,6 +2,7 @@
 ROOT = ../..
 -include $(ROOT)/config.mk
 
+MOD_DIR = src/fnettrace
 PROG = fnettrace
 TARGET = $(PROG)
 

diff --git a/src/fsec-optimize/Makefile b/src/fsec-optimize/Makefile
@@ -2,6 +2,7 @@
 ROOT = ../..
 -include $(ROOT)/config.mk
 
+MOD_DIR = src/fsec-optimize
 PROG = fsec-optimize
 TARGET = $(PROG)
 

diff --git a/src/fsec-print/Makefile b/src/fsec-print/Makefile
@@ -2,6 +2,7 @@
 ROOT = ../..
 -include $(ROOT)/config.mk
 
+MOD_DIR = src/fsec-print
 PROG = fsec-print
 TARGET = $(PROG)
 

diff --git a/src/fseccomp/Makefile b/src/fseccomp/Makefile
@@ -2,6 +2,7 @@
 ROOT = ../..
 -include $(ROOT)/config.mk
 
+MOD_DIR = src/fseccomp
 PROG = fseccomp
 TARGET = $(PROG)
 

diff --git a/src/ftee/Makefile b/src/ftee/Makefile
@@ -2,6 +2,7 @@
 ROOT = ../..
 -include $(ROOT)/config.mk
 
+MOD_DIR = src/ftee
 PROG = ftee
 TARGET = $(PROG)
 

diff --git a/src/fzenity/Makefile b/src/fzenity/Makefile
@@ -2,6 +2,7 @@
 ROOT = ../..
 -include $(ROOT)/config.mk
 
+MOD_DIR = src/fzenity
 PROG = fzenity
 TARGET = $(PROG)
 

diff --git a/src/include/common.h b/src/include/common.h
@@ -41,7 +41,8 @@
 
 #define errExit(msg) do { \
 	char msgout[500]; \
-	snprintf(msgout, 500, "Error %s: %s:%d %s", msg, __FILE__, __LINE__, __func__); \
+	snprintf(msgout, 500, "Error %s/%s:%d %s(): %s", \
+	         MOD_DIR, __FILE__, __LINE__, __func__, msg); \
 	perror(msgout); \
 	exit(1); \
 } while (0)

diff --git a/src/jailcheck/Makefile b/src/jailcheck/Makefile
@@ -2,6 +2,7 @@
 ROOT = ../..
 -include $(ROOT)/config.mk
 
+MOD_DIR = src/jailcheck
 PROG = jailcheck
 TARGET = $(PROG)
 

diff --git a/src/lib/Makefile b/src/lib/Makefile
@@ -2,6 +2,7 @@
 ROOT = ../..
 -include $(ROOT)/config.mk
 
+MOD_DIR = src/lib
 TARGET = lib
 
 include $(ROOT)/src/prog.mk

diff --git a/src/libpostexecseccomp/Makefile b/src/libpostexecseccomp/Makefile
@@ -2,6 +2,7 @@
 ROOT = ../..
 -include $(ROOT)/config.mk
 
+MOD_DIR = src/libpostexecseccomp
 SO = libpostexecseccomp.so
 TARGET = $(SO)
 

diff --git a/src/libtrace/Makefile b/src/libtrace/Makefile
@@ -2,6 +2,7 @@
 ROOT = ../..
 -include $(ROOT)/config.mk
 
+MOD_DIR = src/libtrace
 SO = libtrace.so
 TARGET = $(SO)
 

diff --git a/src/libtracelog/Makefile b/src/libtracelog/Makefile
@@ -2,6 +2,7 @@
 ROOT = ../..
 -include $(ROOT)/config.mk
 
+MOD_DIR = src/libtracelog
 SO = libtracelog.so
 TARGET = $(SO)
 

diff --git a/src/profstats/Makefile b/src/profstats/Makefile
@@ -2,6 +2,7 @@
 ROOT = ../..
 -include $(ROOT)/config.mk
 
+MOD_DIR = src/profstats
 PROG = profstats
 TARGET = $(PROG)
 

diff --git a/test/appimage/filename.exp b/test/appimage/filename.exp
@@ -24,7 +24,7 @@ after 100
 send -- "firejail --appimage appimage.sh\r"
 expect {
 	timeout {puts "TESTING ERROR 2\n";exit}
-	"Error mounting appimage"
+	-re "Error .*mounting appimage"
 }
 after 100