Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Useless lines in disable-common.inc #3358

Closed
rusty-snake opened this issue Apr 15, 2020 · 1 comment · Fixed by #3499
Closed

Useless lines in disable-common.inc #3358

rusty-snake opened this issue Apr 15, 2020 · 1 comment · Fixed by #3499

Comments

@rusty-snake
Copy link
Collaborator

We include disable-common.inc before we set nodbus/dbus-(user|system) none and x11 none.

firejail/etc/disable-common.inc

Lines 67 to 68 in ed0c218

?HAS_X11: blacklist ${HOME}/.ICEauthority
?HAS_X11: blacklist /tmp/.ICE-unix

firejail/etc/disable-common.inc

Lines 139 to 140 in ed0c218

?HAS_NODBUS: blacklist ${RUNUSER}/ksocket-*
?HAS_NODBUS: blacklist /tmp/ksocket-*

@glitsj16
Copy link
Collaborator

@rusty-snake Nice find. Should be safe to take out these useless lines IMO.

@rusty-snake rusty-snake mentioned this issue Jul 7, 2020
Merged
@smitsohu smitsohu mentioned this issue Sep 2, 2020
Closed
@rusty-snake rusty-snake mentioned this issue Mar 7, 2022
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update disable-common.inc rusty-snake/firejail
2 participants
@glitsj16 @rusty-snake