add --noautopulse arg for complex pulse setups #1854
Merged
+26
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
such as remote pulse servers or non-standard socket paths
|
Merged, thanks. |
|
I will also add support today to disable it globally in /etc/firejail/firejail.config, thanks for the patch. |
kmk3
added a commit
to kmk3/firejail
that referenced
this pull request
May 11, 2021
Added on commit 617ff40 ("add --noautopulse arg for complex pulse setups") / PR netblue30#1854. Misc: I noticed that it was missing when comparing it to contrib/vim/syntax/firejail.vim on commit 22a91ae ("contrib/vim: add missing noinput command to syn match") / PR netblue30#4259.
kmk3
added a commit
to kmk3/firejail
that referenced
this pull request
May 11, 2021
Added on commit 617ff40 ("add --noautopulse arg for complex pulse setups") / PR netblue30#1854. Note: The template was added after that, on commit cb98aea ("Add profile templates"). Misc: I noticed that it was missing when comparing it to contrib/vim/syntax/firejail.vim on commit 22a91ae ("contrib/vim: add missing noinput command to syn match") / PR netblue30#4259.
kmk3
added a commit
to kmk3/firejail
that referenced
this pull request
May 14, 2021
Changes: * add the keep-config-pulse option * make noautopulse an alias for keep-config-pulse * deprecate the noautopulse option * misc: fix indentation of --keep-dev-shm on src/firejail/usage.c Even though noautopulse is not intended for hardening, it looks like it is, because it starts with "no", just like no3d, noroot, etc). In fact, it is the only "no" option that differs in such a way. And it has been accidentally misused as such before; see PR netblue30#4269 and commit e4beaea ("drop noautopulse from agetpkg"). So effectively rename it to keep-config-pulse in order to avoid confusion. This is similar to the keep-var-tmp and keep-dev-shm options, which are used to "leave a path alone", just like noautopulse. Note: The changes on this patch are based on the ones from commit 617ff40 ("add --noautopulse arg for complex pulse setups") / PR netblue30#1854. See netblue30#4269 for the discussion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
such as remote pulse servers or non-standard socket paths
closes #1028