profiles: mpv: allow lua #3243
Merged
profiles: mpv: allow lua #3243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rusty-snake
approved these changes
Feb 24, 2020
| @@ -4,5 +4,6 @@ include allow-lua.local | |||
|
|
|||
| noblacklist ${PATH}/lua* | |||
| noblacklist /usr/include/lua* | |||
| noblacklist /usr/lib/liblua* | |||
There was a problem hiding this comment.
Where is the blacklist? grep "/usr/lib/liblua" etc/*.inc
There was a problem hiding this comment.
@rusty-snake I had that in my disable-interpreters.local and forgot about it. Thanks for the catch!
kmk3
added a commit
to kmk3/firejail
that referenced
this pull request
Nov 25, 2024
mpv crashes if luajit is blocked:
$ firejail --quiet --noprofile \
--include=/etc/firejail/disable-interpreters.inc /usr/bin/mpv
/usr/bin/mpv: error while loading shared libraries: libluajit-5.1.so.2: cannot open shared object file: Permission denied
So make sure that allow-lua.inc is always included when mpv paths (such
as ~/.config/mpv) are allowed.
Environment: luajit 2.1.1727870382-1, mpv 1:0.39.0-3 on Artix Linux.
Related commits:
* db2bdaa ("add lua support for mpv (netblue30#3243)", 2020-02-24) /
PR netblue30#3243
* d6a6fb9 ("Allow Lua for mpv in dolphin.profile", 2020-04-18) /
issue netblue30#3363
* f3585e5 ("fixes, closes, enhances, improvements, and so on",
2020-11-09) /
issue netblue30#3686
* 3ec523f ("profiles: anki: allow lua", 2024-11-14) /
PR netblue30#6545
kmk3
added a commit
that referenced
this pull request
Nov 29, 2024
mpv crashes if luajit is blocked:
$ firejail --quiet --noprofile \
--include=/etc/firejail/disable-interpreters.inc /usr/bin/mpv
/usr/bin/mpv: error while loading shared libraries: libluajit-5.1.so.2: cannot open shared object file: Permission denied
So make sure that allow-lua.inc is always included when mpv paths (such
as ~/.config/mpv) are allowed.
Environment: luajit 2.1.1727870382-1, mpv 1:0.39.0-3 on Artix Linux.
Related commits:
* db2bdaa ("add lua support for mpv (#3243)", 2020-02-24) /
PR #3243
* d6a6fb9 ("Allow Lua for mpv in dolphin.profile", 2020-04-18) /
issue #3363
* f3585e5 ("fixes, closes, enhances, improvements, and so on",
2020-11-09) /
issue #3686
* 3ec523f ("profiles: anki: allow lua", 2024-11-14) /
PR #6545
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Arch mpv needs access to lua:
On a side-note, Python support (enabled in the mpv profile) doesn't seem to be needed, at least not on Arch. Need to check on a Ubuntu machine to confirm.